-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rabbitmq Docker tag to v4 #8481
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8481 +/- ##
=======================================
Coverage 65.97% 65.97%
=======================================
Files 597 597
Lines 60678 60678
Branches 6200 6203 +3
=======================================
+ Hits 40032 40034 +2
+ Misses 20646 20644 -2 ☔ View full report in Codecov by Sentry. |
Attention ! Major bump, so better test properly the impacted features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be synchronized with https://github.com/OpenCTI-Platform/docker/blob/master/docker-compose.yml, please do not merge.
be56acd
to
07897d3
Compare
Hi Filigran team! Just a heads up that this may cause some problems with connectors. I know my CrowdStrike connector broke when I started bumping the rabbitmq versions. This PR changes the default maximum message size to 16MB in rabbitmq version 4. I observed the connector failing on v4 due to message sizes a bit larger than this. |
Thanks for the heads up @initstring, we will pay attention to that connector. |
Noting everything about rabbitMQ 4 in a dedicated issue #8894 |
This PR contains the following updates:
3.13-management
->4.0-management
3.13-management
->4.0-management
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.